Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dyaml and Configy dependency to their latest release / HEAD #3330

Open
wants to merge 2 commits into
base: v0.x.x
Choose a base branch
from

Conversation

Geod24
Copy link
Collaborator

@Geod24 Geod24 commented Aug 30, 2022

No description provided.

Copy link
Contributor

@hewison-chris hewison-chris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hewison-chris hewison-chris enabled auto-merge (rebase) August 30, 2022 06:09
@Geod24
Copy link
Collaborator Author

Geod24 commented Aug 30, 2022

Can you re-trigger integration ?

@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #3330 (4daad44) into v0.x.x (d2ad13b) will decrease coverage by 1.30%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           v0.x.x    #3330      +/-   ##
==========================================
- Coverage   88.72%   87.41%   -1.31%     
==========================================
  Files         165      164       -1     
  Lines       17112    16999     -113     
==========================================
- Hits        15182    14860     -322     
- Misses       1930     2139     +209     
Flag Coverage Δ
integration ?
unittests 87.41% <ø> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/agora/node/Runner.d 0.00% <0.00%> (-55.56%) ⬇️
source/agora/network/RPC.d 1.90% <0.00%> (-53.34%) ⬇️
source/agora/network/VibeManager.d 1.38% <0.00%> (-48.62%) ⬇️
source/agora/test/NetworkManager.d 63.88% <0.00%> (-33.34%) ⬇️
source/scpd/types/Stellar_SCP.d 68.99% <0.00%> (-30.24%) ⬇️
source/agora/network/Clock.d 72.22% <0.00%> (-16.67%) ⬇️
source/agora/common/Task.d 88.88% <0.00%> (-11.12%) ⬇️
source/agora/utils/Log.d 57.50% <0.00%> (-5.00%) ⬇️
source/agora/node/Config.d 64.96% <0.00%> (-3.65%) ⬇️
source/agora/node/FullNode.d 70.53% <0.00%> (-2.39%) ⬇️
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@omerfirmak
Copy link
Contributor

Can you re-trigger integration ?

Failed again

auto-merge was automatically disabled October 17, 2022 10:07

Head branch was pushed to by a user without write access

@Geod24
Copy link
Collaborator Author

Geod24 commented Oct 17, 2022

@hewison-chris : Looks like Faucet was deleted / made private and that broke the CI.

@hewison-chris
Copy link
Contributor

@hewison-chris : Looks like Faucet was deleted / made private and that broke the CI.

It was renamed and made private. It is restored now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants